Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pugixml: Fix pkg-config file installation and use fetchFromGitHub [19.03] #56832

Merged
merged 2 commits into from Mar 5, 2019
Merged

pugixml: Fix pkg-config file installation and use fetchFromGitHub [19.03] #56832

merged 2 commits into from Mar 5, 2019

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Mar 4, 2019 •
edited

Motivation for this change

Changes were merged into master after branch-off, this fixes the filezilla issues.
pugixml: Fix pkg-config file installation and use fetchFromGitHub

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented Mar 4, 2019 •
edited

filezilla builds, but fails to execute with a SIGSEGV. That's probably a conflict on my system, but I'd prefer if someone else could verify this.

$ LANG=C /nix/store/plac3bfdrqrmwz5ywlg6rdxwfq2pig63-filezilla-3.31.0/bin/filezilla
Reading locale option from /home/dfrank/.config/filezilla/filezilla.xml

(filezilla:10342): Gtk-WARNING **: 19:03:54.066: Unable to locate theme engine in module_path: "adwaita",

(filezilla:10342): Gtk-WARNING **: 19:03:54.070: Unable to locate theme engine in module_path: "adwaita",
Segmentation fault

@tokudan tokudan changed the title [WIP] pugixml: Fix pkg-config file installation and use fetchFromGitHub pugixml: Fix pkg-config file installation and use fetchFromGitHub Mar 4, 2019
@tokudan tokudan changed the title pugixml: Fix pkg-config file installation and use fetchFromGitHub pugixml: Fix pkg-config file installation and use fetchFromGitHub [19.03] Mar 4, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from pSub March 4, 2019 18:10
jokogr
jokogr approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@jokogr jokogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied this to release-19.03 and it was properly working for me, I've managed even to resume a transfer and session manager was working.

@tokudan Could you maybe start this with an empty .config/filezilla?

@pSub pSub added this to the 19.03 milestone Mar 5, 2019
@tokudan
Copy link
Contributor Author

tokudan commented Mar 5, 2019

@tokudan Could you maybe start this with an empty .config/filezilla?

I already tried that. I guess it's a conflict with my 18.09 installation or my specific Gnome/GTK configuration.

Since it works for @jokogr and since it's been approved by pSub, I guess it's ready for #56826 to fix the Filezilla failure.

@jokogr jokogr merged commit 58e31b2 into NixOS:release-19.03 Mar 5, 2019
@tokudan tokudan mentioned this pull request Mar 5, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

@jokogr jokogr jokogr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
19.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tokudan @pSub @jokogr @GrahamcOfBorg