Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome2: remove aliases #56791

Merged
merged 2 commits into from Mar 5, 2019
Merged

gnome2: remove aliases #56791

merged 2 commits into from Mar 5, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 3, 2019

Motivation for this change

cc @hedning @ryantm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to To do in Picking up garbage via automation Mar 3, 2019
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 3, 2019

Maybe the weird scoping was what caused haskell2nix to pick aliases from gnome2 instead of pkgs.

@jtojnar jtojnar merged commit 57c745f into NixOS:master Mar 5, 2019
Picking up garbage automation moved this from To do to Done Mar 5, 2019
@jtojnar jtojnar deleted the gnome2-noaliases branch March 5, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg