New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codechange: [C++11] Use override specifer for overriding member declarations #7324
Conversation
4025137
to
8ccff43
Compare
Well done. I had started to do this myself but didn't get any near completing it. I am not sure if the remaining The only issue I see is the Mac OS build warns on compiling objc files which include other headers: |
Many Window-derived classes incorrectly use I've pushed to my repo with a PR here: M3Henry#1 |
I'd say they should go. I do remember GCC sometimes backports features and then warns that the feature is not compiler agnostic. Perhaps something similar? |
9603846
to
d0d6210
Compare
d0d6210
to
424c83e
Compare
There's a bunch of new useless warnings in the CI output for OSX. You could try adding the following to config.lib around line 1324: We do want to use C++11, after all. |
424c83e
to
226eed3
Compare
Sorry @M3Henry, I should have said line 1323, i.e. just before the |
This is a C++11 feature that allows the compiler to check that a virtual member declaration overrides a base-class member with the same signature. Also src/blitter/32bpp_anim_sse4.hpp +38 is no longer erroneously marked as virtual despite being a template.
226eed3
to
62ba3e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. And if there's missing override
somewhere, well, no harm in adding it later.
This is a C++11 feature that allows the compiler to check that a virtual
member declaration overrides a base-class member with the same signature.
Also src/blitter/32bpp_anim_sse4.hpp +38 is no longer erroneously marked
as virtual despite being a template.