Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fragments: init at 1.3 #56793

Closed
wants to merge 1 commit into from
Closed

fragments: init at 1.3 #56793

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Got carried away when I saw #56784 馃槃

The build system for Fragments Is kinda problematic in nix because of how it builds the latest transmission.

Also couldn't get libz to go in submodules/meson.build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 3, 2019

Can we package the transmission as a separate derivation?

@jtojnar
Copy link
Contributor

jtojnar commented Mar 3, 2019

Yeah, find_library should always omit lib prefix. This is an upstream bug.

@worldofpeace
Copy link
Contributor Author

Can we package the transmission as a separate derivation?

I think so.
I'd have to sync it with whatever version the submodule is checked out at transmission/transmission@4a4233f and add a patch to use it.

ryantm
ryantm approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on NixOS and it seems to work fine for me. Any reason it hasn't been merged yet?

@jtojnar
Copy link
Contributor

jtojnar commented Jan 6, 2020

IIRC, we wanted to build transmission as subpackage. Also at this point it is outdated.

@worldofpeace
Copy link
Contributor Author

In latest fragments it seems to bundle transmission with flatpak https://gitlab.gnome.org/World/Fragments/commit/1665c64164f4c865239742948a11797ed0f79836, and it lacks this feature https://gitlab.gnome.org/World/Fragments/issues/30 which makes me disinterested.

@onny
Copy link
Contributor

onny commented Aug 14, 2020

For testing purpose I continued this package in my NUR repository. You can try the package nur.repos.onny.fragments if you want :) I've packaged version 1.4. Still not sure which features might be missing or bugs still present.

This was referenced Aug 1, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@worldofpeace @jtojnar @onny @ryantm @GrahamcOfBorg