Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict vim update.py to generated.nix #56191

Merged
merged 1 commit into from Mar 3, 2019
Merged

Restrict vim update.py to generated.nix #56191

merged 1 commit into from Mar 3, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Feb 22, 2019

Motivation for this change

#55857 broke pkgs/misc/vim-plugins/update.py. (#55857 (comment)).

Things done

This change modifies the script to only look for updates for plugins that are defined in generated.nix.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobim tobim mentioned this pull request Feb 22, 2019
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/error-running-update-when-adding-vim-plugins/2224/2

@teto teto mentioned this pull request Feb 28, 2019
Merged
10 tasks
@srhb srhb requested a review from Mic92 March 2, 2019 11:17
@Mic92 Mic92 merged commit 34aa254 into NixOS:master Mar 3, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 3, 2019

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobim @nixos-discourse @Mic92 @GrahamcOfBorg