Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdwarf: add zlib to buildInputs #56792

Merged
merged 1 commit into from Mar 15, 2019
Merged

libdwarf: add zlib to buildInputs #56792

merged 1 commit into from Mar 15, 2019

Conversation

timor
Copy link
Member

@timor timor commented Mar 3, 2019 •
edited

Motivation for this change

Without this, dwarfdump gives errors when trying to show debug information
with compressed dwarf sections.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timor
libdwarf: add zlib to buildInputs
a07438d 
Without this, `dwarfdump` gives errors when trying to show debug information
with compressed dwarf sections.
@timor
Copy link
Member Author

timor commented Mar 4, 2019

For changes like this, should there be a version-suffix update?

timor added a commit to timor/timor-overlay that referenced this pull request Mar 4, 2019
@timor
libdwarf: add zlib to buildInputs
8f34306 
(until NixOS/nixpkgs#56792 is merged)
@timor
Copy link
Member Author

timor commented Mar 5, 2019

cc @Mic92 (based on git blame info for dwarfdump)

@matthewbauer matthewbauer merged commit 6d52e26 into NixOS:master Mar 15, 2019
@timor timor deleted the libdwarf-dwarfdump-zlib branch March 15, 2019 22:13
@timor timor restored the libdwarf-dwarfdump-zlib branch March 29, 2019 07:05
@Atry Atry mentioned this pull request May 19, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timor @matthewbauer @GrahamcOfBorg