Skip to content

zram: revert "change default algorithm to zstd" (19.03) #56856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Mar 4, 2019

19.03 default kernel is still 4.14, which doesn't support zstd. So,
zramSwap in current fasion fails on default kernel.

Kernel was revert after my zram-zstd patch landed #55092

19.03 default kernel is still 4.14, which doesn't support zstd. So,
zramSwap in current fasion fails on default kernel.
@danbst danbst requested a review from infinisil as a code owner March 4, 2019 23:36
@danbst
Copy link
Contributor Author

danbst commented Mar 4, 2019

cc @samueldr

@danbst
Copy link
Contributor Author

danbst commented Mar 4, 2019

🤔 I hope there won't be problem that this has to be backported to master, right? Or should I first commit to master and then backport to 19.03?

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 4, 2019
@danbst danbst added this to the 19.03 milestone Mar 5, 2019
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think cherry-picking to master from 19.03 would be weird though.

@danbst danbst merged commit 940f396 into NixOS:release-19.03 Mar 7, 2019
@danbst danbst deleted the revert-zram-zstd branch March 7, 2019 00:07
@danbst
Copy link
Contributor Author

danbst commented Mar 7, 2019

neverless, 🍒 -ed this to master ef1911d . Will do better next time

danbst added a commit that referenced this pull request Mar 7, 2019
19.03 default kernel is still 4.14, which doesn't support zstd. So,
zramSwap in current fasion fails on default kernel.
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
19.03 default kernel is still 4.14, which doesn't support zstd. So,
zramSwap in current fasion fails on default kernel.
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
19.03 default kernel is still 4.14, which doesn't support zstd. So,
zramSwap in current fasion fails on default kernel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants