Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPy: 7.0.0 #56817

Closed
wants to merge 3 commits into from
Closed

PyPy: 7.0.0 #56817

wants to merge 3 commits into from

Conversation

MostAwesomeDude
Copy link
Contributor

@MostAwesomeDude MostAwesomeDude commented Mar 4, 2019 •
edited

Motivation for this change

We should have a robust PyPy story in place so that we can smoothly deprecate CPython 2 in concert with PSF.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MostAwesomeDude
python: Make .isPyPy flag more accurate.
2e928a3 
nix-repl> map (s: s.isPyPy) [ python python3 pypy pypy3 ]
[ false false true true ]
@MostAwesomeDude
pypy: 6.0.0 -> 7.0.0
a37e611 
Note that this bumps both the 2.7 and 3.5 flavors of PyPy.
@MostAwesomeDude
pypy: Disable broken test on 3.x.
59e5d9b
@gebner
Copy link
Member

gebner commented Mar 4, 2019

[...] smoothly deprecate CPython in concert with PSF.

Can you elaborate on this part? I find it hard to believe that the PSF is deprecating CPython. (Or is this about python 2?)

@MostAwesomeDude
Copy link
Contributor Author

This is only about Python 2. Sorry about that; a missing character can make all the difference.

CPython 2.7 is going away next year upstream, and I think that we can be prepared with PyPy.

@MostAwesomeDude MostAwesomeDude marked this pull request as ready for review March 4, 2019 13:25
@infinisil
Copy link
Member

You also have #55182 open btw

@risicle
Copy link
Contributor

risicle commented Apr 10, 2019 •
edited

Builds and works for me on non-nixos linux x86_64 fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MostAwesomeDude @gebner @infinisil @risicle @GrahamcOfBorg