Add: Detect stable tags automatically, and set the 'stable' flag in '… #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_openttd_newgrf_version' accordingly.
|
Is it possible to do the assertions part automatically with this too? |
|
MSVC project files will still need to be updated to remove the define |
|
While not necessarily required, it'd be nice to get this in before branching... |
|
I don't think this can automatically do the assert thingie. I also think that changing build parameters like assertions/stripping should be set by the compile farm, not by the source code. |
|
Yeah, that sounds reasonable. |
|
Confirmed working with MSVC. |
PeterN
approved these changes
Mar 3, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
…_openttd_newgrf_version' accordingly. (OpenTTD#7317)
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
…_openttd_newgrf_version' accordingly. (OpenTTD#7317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_openttd_newgrf_version' accordingly.
In SVN we made changed between branches and tags:
This implements the "stable" flag.
It does not do anything about the assertions.