Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ppft: use custom checkPhase #56910

Merged
merged 1 commit into from Mar 5, 2019
Merged

pythonPackages.ppft: use custom checkPhase #56910

merged 1 commit into from Mar 5, 2019

Conversation

samhug
Copy link
Contributor

@samhug samhug commented Mar 5, 2019

Motivation for this change

Fixes #56908

doCheck = true; fails on python3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samhug samhug requested a review from FRidh as a code owner March 5, 2019 20:20
FRidh
FRidh requested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A custom checkPhase seems to be needed instead.

@samhug
Copy link
Contributor Author

samhug commented Mar 5, 2019

@FRidh thanks for taking a look. You're right. It looks like the project uses python -m ppft.tests to run tests. I'll update the pull request with a custom checkPhase.

@samhug samhug changed the title pythonPackages.ppft: disable checks for python3 pythonPackages.ppft: use custom checkPhase Mar 5, 2019
@worldofpeace worldofpeace merged commit cc6d98b into NixOS:master Mar 5, 2019
@worldofpeace
Copy link
Contributor

Backported in dcaf6f4

@samhug samhug deleted the fix/56908-ppft branch March 5, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.ppft: check phase fails
5 participants
@samhug @worldofpeace @FRidh @GrahamcOfBorg @Janik-Haag