openafs: fix OpenAFS 1.6 on Linux 4.20 #56862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch cherry-picks commits from the OpenAFS git repository using `git show` to add support for Linux 4.20 for OpenAFS 1.6. There do not seem to be patches in the Git repository for full Linux 5.0 support, although I have added the ones which exist so far. This patch has been tested on Linux 4.4, 4.14, 4.20, and is confirmed to fail on Linux 5.0. It does not change the drv of the openafs package, only linuxPackages_*.openafs.
|
cc @spacefrogg |
|
@GrahamcOfBorg build linuxPackages_4_20.openafs Edit, oops, I can't do this. Can someone else run this for me? |
|
@GrahamcOfBorg build linuxPackages_4_20.openafs |
|
@GrahamcOfBorg build linuxPackages_4_20.openafs |
veprbl
reviewed
Mar 5, 2019
10 tasks
veprbl
approved these changes
Mar 6, 2019
|
@artemist Thanks for the effort! Looks good from my side. |
|
@veprbl That's an annoying issue with struct layout randomization. i'm writing a patch I'll submit upstream after some testing, but it's out of scope for this PR (and quite possibly nixpkgs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I have been requested to add linuxPackages_latest support to OpenAFS 1.6. I found working patches, although not enough for 5.0
Things done
This patch cherry-picks commits from the OpenAFS git repository using
git showto add support for Linux 4.20 for OpenAFS 1.6.There do not seem to be patches in the Git repository for full Linux 5.0
support, although I have added the ones which exist so far.
This patch has been tested on Linux 4.4, 4.14, 4.20, and is confirmed to
fail on Linux 5.0. It does not change the drv of the openafs package,
only linuxPackages_*.openafs.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)