Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pari: fix off-by-one error #56905

Merged
merged 3 commits into from Mar 6, 2019
Merged

pari: fix off-by-one error #56905

merged 3 commits into from Mar 6, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 5, 2019

Motivation for this change

Fixes an upstream bug, brought to my attention by sage. May cause a segfault (or even have security implications, though unlikely). While I'm at it I've also done a slight refactoring and added myself as a maintainer (so that I'll be notified on changes which may break sage).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Use pname, one line per argument.
I'm mostly interested in this package because it is a dependency of
sage. I'd like to be notified on changes (which ofBorg will do when I'm
listed as a maintainer).
@Mic92
Copy link
Member

Mic92 commented Mar 5, 2019

@GrahamcOfBorg build pari

Done by applying upstream patch. Will be included in the next release.

Upstream: https://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=2117
@timokau
Copy link
Member Author

timokau commented Mar 5, 2019

Oops, forgot to stage a fix. I wonder why ofBorg didn't build it automatically though.

@GrahamcOfBorg build pari

@Mic92 Mic92 merged commit 9b57d85 into NixOS:master Mar 6, 2019
@timokau timokau mentioned this pull request Mar 16, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants