Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: 2.11.0 -> 2.13.0 #56837

Closed
wants to merge 1 commit into from
Closed

helm: 2.11.0 -> 2.13.0 #56837

wants to merge 1 commit into from

Conversation

markus1189
Copy link
Contributor

Reverting back to binary download, because generating nix build from
source does not work with current state of helm and dep init

Motivation for this change

The current helm version was quite old (2.11.0).
This reverts back to downloading the pre-built binary, because I couldn't get a working build from source.

It seems like there is a bug in dep that leads to a problem when calling dep init on the downloaded helm repository: golang/dep#1841

Instead of waiting for all the possible upstream fixes (fix in dep, helm switching from glide to dep, ...) I decided to revert back to the binary download. Maybe at a later time we can re-introduce a source-build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markus1189
helm: 2.11.0 -> 2.13.0
b888f82 
Reverting back to binary download, because generating nix build from
source does not work with current state of `helm` and `dep init`
@lightbulbjim
Copy link
Contributor

Note this package is actually named kubernetes-helm in pkgs/top-level/all-packages.nix. helm is a different package altogether.

@brodul
Copy link
Contributor

brodul commented Jun 6, 2019

Current 2.11.0 helm in nixpkgs is quite buggy.

For example the version does not match semver scheme.

helm version
Client: &version.Version{SemVer:"v2.11.0+unreleased", GitCommit:"", GitTreeState:""}

That leads to errors:

brodul:code/ $ helm tiller install
Installed Helm version &version.Version{SemVer
Installed Tiller version v2.11.0+unreleased
Installing Tiller v&ersion.Version{SemVer ...
version &ersion.Version{SemVer does not match the semver scheme 'X.Y.Z(-PRERELEASE)(+BUILD)'. See help for more information.                                            
Error: plugin "tiller" exited with error

@yurrriq
Copy link
Member

yurrriq commented Jun 6, 2019

👍 to this, but I'd recommend v2.14.1 now.

@aanderse
Copy link
Member

triage: What is the state of this PR? Still waiting on upstream?

@yurrriq
Copy link
Member

yurrriq commented Jul 15, 2019

In my opinion, the binary approach here is solid, but the version should be 2.14.2 at this point.

@aanderse
Copy link
Member

@markus1189 Are you able to continue working on this PR and update as requested?

@markus1189
Copy link
Contributor Author

markus1189 commented Jul 16, 2019 via email

@markus1189
Copy link
Contributor Author

Updated with the binary build of 2.14.2 . I did not check whether source build would work again though

@aanderse
Copy link
Member

@edude03 @teozkr @nlewo @yurrriq Can I get one or more of you to either approve or approve and merge this PR?

@nightkr
Copy link
Member

nightkr commented Jul 17, 2019

@aanderse I'm not familiar enough with the Go ecosystem to have a strong opinion on this. I'd generally prefer to stick to source builds but if that's not viable for now then staying up to date probably takes precedence.

@edude03
Copy link
Contributor

edude03 commented Jul 17, 2019

I think we should stick with the source build and figure out the dep issue if possible. I managed to get it to work before and I'm sure I could again, although I won't have time to look at it until friday most likely.

@edude03 edude03 mentioned this pull request Jul 17, 2019
Merged
10 tasks
@aanderse aanderse closed this Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@markus1189 @lightbulbjim @brodul @yurrriq @aanderse @nightkr @edude03 @infinisil @GrahamcOfBorg