New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: 2.11.0 -> 2.13.0 #56837
helm: 2.11.0 -> 2.13.0 #56837
Conversation
Reverting back to binary download, because generating nix build from source does not work with current state of `helm` and `dep init`
Note this package is actually named |
Current For example the
That leads to errors:
|
👍 to this, but I'd recommend v2.14.1 now. |
triage: What is the state of this PR? Still waiting on upstream? |
In my opinion, the binary approach here is solid, but the version should be 2.14.2 at this point. |
@markus1189 Are you able to continue working on this PR and update as requested? |
I'll have a look!
…On Tue, Jul 16, 2019, 02:37 Aaron Andersen ***@***.***> wrote:
@markus1189 <https://github.com/markus1189> Are you able to continue
working on this PR and update as requested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56837?email_source=notifications&email_token=AAEQNT6UR6QCS3V3ONMHI2DP7UJ4HA5CNFSM4G3T7Q32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7LBAQ#issuecomment-511619202>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEQNT4BNPXGLZ5NVBBQL6DP7UJ4HANCNFSM4G3T7Q3Q>
.
|
Updated with the binary build of |
@aanderse I'm not familiar enough with the Go ecosystem to have a strong opinion on this. I'd generally prefer to stick to source builds but if that's not viable for now then staying up to date probably takes precedence. |
I think we should stick with the source build and figure out the dep issue if possible. I managed to get it to work before and I'm sure I could again, although I won't have time to look at it until friday most likely. |
Reverting back to binary download, because generating nix build from
source does not work with current state of
helm
anddep init
Motivation for this change
The current helm version was quite old (
2.11.0
).This reverts back to downloading the pre-built binary, because I couldn't get a working build from source.
It seems like there is a bug in
dep
that leads to a problem when callingdep init
on the downloadedhelm
repository: golang/dep#1841Instead of waiting for all the possible upstream fixes (fix in dep, helm switching from glide to dep, ...) I decided to revert back to the binary download. Maybe at a later time we can re-introduce a source-build.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)