Fix #7308: MinGW build with SDL #7318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
requested changes
Mar 3, 2019
There was a problem hiding this comment.
Can you please make 3 commits out of this? Otherwise it is very annoying in the history to see what was going on ;) Especially as things turn out to be unwanted .. like I am unsure if we want to change 'static-libs' into '--libs --static'. And the zlib-config thing is weird, as if this doesn't work, it should constantly complain. You have me confused by bringing more to the table than suggested ;)
TrueBrain
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also static build with SDL generally. And a zlib variable that was wrong