udiskie: fix build #56783
udiskie: fix build #56783
Conversation
It was broken by b4acd97. Fixes NixOS#56771.
dotlambda
added
the
9.needs: port to stable
| librsvg # required for loading svg icons (udiskie uses svg icons) | ||
| gobject-introspection |
There was a problem hiding this comment.
| gobject-introspection |
There was a problem hiding this comment.
That yields
$ udiskie -t &
Typelib for 'libnotify' is not available. Possible causes include:
- libnotify is not installed
- the typelib is provided by a separate package
- libnotify was built with introspection disabled
Starting udiskie without notifications.
Typelib for 'Gtk 3.0' is not available. Possible causes include:
- GTK3 is not installed
- the typelib is provided by a separate package
- GTK3 was built with introspection disabled
Starting udiskie without tray icon.
That's why I put it in both.
There was a problem hiding this comment.
Weird, I would expect setup hooks to work front nativeBuildInputs even with strictDeps.
|
We have |
|
Binaries seem to work and it builds so fine by me. Thanks ! |
|
@dotlambda It does not seem broken on 19.03: https://hydra.nixos.org/job/nixos/release-19.03/nixpkgs.udiskie.x86_64-linux/all - should we backport anyway? |
It's broken on |
|
@dotlambda I'm not 100% sure about this, but can you explain why you moved libappindicator-gtk3 out of the propagated build inputs. My recollection is that the appindicator functionality does not work without it being there |
|
|
|
As stated above,
I simply moved all non-Python dependencies out of |
samueldr
removed
the
9.needs: port to stable
Motivation for this change
It was broken by b4acd97.
Fixes #56771.
I'm not sure I know enough about GTK to determine which dependencies belong where. Feedback is welcome.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @teto