Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackage2nix: ignore aliases #411

Closed
wants to merge 1 commit into from
Closed

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 5, 2019

Real solution to #410

Depends on NixOS/distribution-nixpkgs#6

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 5, 2019

When I ran hackage2nix locally, it fixed the majority of issues. Paging through diff, some new appeared:

  • gnome-keyring had libgnome_keyring changed to null
  • webkit2gtk3-javascriptcore had webkitgtk changed to null (though some other packages like webkit-javascriptcore did not)
  • qr-imager had libqrencode changed to null

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 5, 2019

Nah, it looks like pkgs.gnome2.gtk is still used.

peti added a commit that referenced this pull request Mar 5, 2019
Closing #411.

Suggested-by: Jan Tojnar <jtojnar@gmail.com>
peti added a commit that referenced this pull request Mar 5, 2019
@peti
Copy link
Member

peti commented Mar 5, 2019

When I ran hackage2nix locally, it fixed the majority of issues. Paging through diff, some new appeared: [...]

These name lookups are fixed by 5012521.

@peti
Copy link
Member

peti commented Mar 5, 2019

Thank you very much for your help!

@jtojnar jtojnar closed this Mar 5, 2019
@jtojnar jtojnar deleted the h2n-no-alias branch March 5, 2019 20:22
Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this pull request Mar 7, 2022
Closing NixOS#411.

Suggested-by: Jan Tojnar <jtojnar@gmail.com>
Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants