Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunvox: 1.9.3b -> 1.9.4c #56888

Merged
merged 1 commit into from Apr 7, 2019
Merged

sunvox: 1.9.3b -> 1.9.4c #56888

merged 1 commit into from Apr 7, 2019

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

updated to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timokau
timokau approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@timokau
Copy link
Member

timokau commented Apr 7, 2019

@GrahamcOfBorg build sunvox

@timokau timokau merged commit cf7b111 into NixOS:master Apr 7, 2019
@xeji xeji mentioned this pull request Apr 7, 2019
Closed
@elohmeier elohmeier deleted the sunvox branch May 31, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elohmeier @timokau @infinisil @GrahamcOfBorg