Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyopencl: Fix build #56847

Closed
wants to merge 2 commits into from
Closed

pythonPackages.pyopencl: Fix build #56847

wants to merge 2 commits into from

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes pyopencl. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 4, 2019 20:55
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build pythonPackages.pyopencl python3Packages.pyopencl

@Ma27
Copy link
Member

Ma27 commented Mar 5, 2019

I filed a patch to fix pyopencl some time ago, there's a pending discussion how to deal with pybind11 properly: #56082

@knedlsepp
Copy link
Member Author

Thx for the note. Closing in favor of #56082

@knedlsepp knedlsepp closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @Ma27 @GrahamcOfBorg