Skip to content

ghc863: dont add extra libs #56795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Mar 4, 2019
Merged

ghc863: dont add extra libs #56795

merged 0 commits into from
Mar 4, 2019
+3 −0

Conversation

matthewbauer
Copy link
Member

Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

This was missing from 8.6.3.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg requested a review from kosmikus March 4, 2019 01:29
@peti peti changed the base branch from master to haskell-updates March 4, 2019 09:56
@peti peti force-pushed the haskell-updates branch from 749dd2a to 33b426d Compare March 4, 2019 09:56
@peti peti merged this pull request into haskell-updates Mar 4, 2019
@peti peti deleted the matthewbauer-patch-1 branch March 4, 2019 09:57
peti pushed a commit that referenced this pull request Mar 4, 2019
@matthewbauer @peti
ghc863: dont add extra libs
3aa9ceb 
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
matthewbauer added a commit that referenced this pull request Mar 4, 2019
@matthewbauer
ghc863: dont add extra libs
6ba15cd 
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
matthewbauer added a commit that referenced this pull request Mar 4, 2019
@matthewbauer
ghc863: dont add extra libs

Verified

This commit was signed with the committer’s verified signature.
politas Myk
GPG key ID: 47938AAEAD85818F
Verified
Learn about vigilant mode
906d432 
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
peti pushed a commit that referenced this pull request Mar 5, 2019
@matthewbauer @peti
ghc863: dont add extra libs
1f21256 
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
ghc863: dont add extra libs
7f27857 
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request NixOS#56795 from @matthewbauer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@peti peti

@kosmikus kosmikus

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @peti @GrahamcOfBorg