Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc863: dont add extra libs #56795

Merged
merged 1 commit into from Mar 4, 2019
Merged

ghc863: dont add extra libs #56795

merged 1 commit into from Mar 4, 2019

Conversation

matthewbauer
Copy link
Member

Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

This was missing from 8.6.3.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.
@peti peti changed the base branch from master to haskell-updates March 4, 2019 09:56
@peti peti merged commit e02143d into haskell-updates Mar 4, 2019
@peti peti deleted the matthewbauer-patch-1 branch March 4, 2019 09:57
peti pushed a commit that referenced this pull request Mar 4, 2019
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
matthewbauer added a commit that referenced this pull request Mar 4, 2019
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
matthewbauer added a commit that referenced this pull request Mar 4, 2019
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
peti pushed a commit that referenced this pull request Mar 5, 2019
Don’t add -liconv to LDFLAGS automatically so that GHC will add it itself.

Merged in pull request #56795 from @matthewbauer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants