Skip to content

transifex-client: Fix build after updated dependencies #56816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

transifex-client: Fix build after updated dependencies #56816

merged 1 commit into from
Mar 11, 2019
+5 −3

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 4, 2019

Motivation for this change

Their requirements.txt file specify deps of very specific versions, and I've tested the program on our local projects and it works with newer dependencies as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@etu
transifex-client: Fix build after updated dependencies

Verified

This commit was signed with the committer’s verified signature.
zimbatm Jonas Chevalier
GPG key ID: 71BAF6D40C1D63D7
Verified
Learn about vigilant mode
13c701e
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 4, 2019
@etu etu merged commit 9388152 into NixOS:master Mar 11, 2019
@etu etu deleted the transifex-fix-build branch March 11, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @GrahamcOfBorg