Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gcovr: Fix build #56851

Merged
merged 3 commits into from Jun 1, 2019
Merged

pythonPackages.gcovr: Fix build #56851

merged 3 commits into from Jun 1, 2019

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 4, 2019 •
edited

Motivation for this change

This fixes pythonPackages.gcovr. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 4, 2019 21:44
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build python2Packages.gcovr python3Packages.gcovr

worldofpeace
worldofpeace reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even used as python module?

@worldofpeace
Copy link
Contributor

Could you also use the https url for the homepage?

@knedlsepp
Copy link
Member Author

knedlsepp commented Mar 5, 2019 •
edited

@worldofpeace Done. Also added an alias to use the package simply as nixpkgs.gcovr.

worldofpeace
worldofpeace suggested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see any tests being ran so they should be disabled

doCheck = false;

Or change the source to github and try to enable them.

@worldofpeace
Copy link
Contributor

ping @knedlsepp

@knedlsepp
pythonPackages.gcovr: Fix build
5e2ac86
@knedlsepp
pythonPackages.gcovr: Fixup homepage
f13fdf4
@knedlsepp
gcovr: Add alias to pythonPackages.gcovr
f10b0c6 
Since gcovr is most likely to be used as a script instead of a library,
we provide an alias to python3Packages.gcovr. We still keep
python2/3Packages.gcovr in case somebody really wants to import it as a
library, which can not entirely be ruled out.
@knedlsepp
Copy link
Member Author

@worldofpeace Sorry for the late reply. Did fixup the suggestions that you made. I tried switching to the github source for the tests, finally could make it work by disabling hardening flags and using gcc5 + some manual patching. Since the tests highly depend on the gcc version I figured it wasn't really worth the maintenance effort on our side.

@worldofpeace
Copy link
Contributor

@worldofpeace Sorry for the late reply. Did fixup the suggestions that you made. I tried switching to the github source for the tests, finally could make it work by disabling hardening flags and using gcc5 + some manual patching. Since the tests highly depend on the gcc version I figured it wasn't really worth the maintenance effort on our side.

Indeed that is true. We can wait for upstream for that.

Thanks for completing this ✨
I've looked over the diff and it looks good, everything builds too.

worldofpeace
worldofpeace approved these changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

@worldofpeace worldofpeace merged commit 3a8a08d into NixOS:master Jun 1, 2019
@worldofpeace
Copy link
Contributor

backported in

@knedlsepp
Copy link
Member Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @worldofpeace @GrahamcOfBorg