Skip to content

pythonPackages.mxnet: Fix build #56848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

pythonPackages.mxnet: Fix build #56848

merged 1 commit into from
Mar 7, 2019
+3 −3

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes pzthonPackages.mxnet. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 4, 2019 21:19
@GrahamcOfBorg GrahamcOfBorg requested a review from abbradar March 4, 2019 21:36
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 4, 2019
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build python2Packages.mxnet python3Packages.mxnet

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

aarch64 failure is unrelated to this fix

@xeji xeji merged commit 8112931 into NixOS:master Mar 7, 2019
xeji pushed a commit that referenced this pull request Mar 7, 2019
@knedlsepp @xeji
pythonPackages.mxnet: Fix build (#56848)
41dd4fb 
(cherry picked from commit 8112931)
@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

backported in 41dd4fb

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
pythonPackages.mxnet: Fix build (NixOS#56848)
76a14bb
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
pythonPackages.mxnet: Fix build (NixOS#56848)
f75af28 
(cherry picked from commit 8112931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@abbradar abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @xeji @GrahamcOfBorg