Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shotcut: 18.12.23 -> 19.02.28 #56875

Merged
merged 1 commit into from Mar 8, 2019
Merged

shotcut: 18.12.23 -> 19.02.28 #56875

merged 1 commit into from Mar 8, 2019

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Mar 5, 2019 •
edited

fixes build with qt 5.12, apparently

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@woffs
shotcut: 18.12.23 -> 19.02.28
f416fde 
fixes build with qt 5.12, apparently
@Mic92
Copy link
Member

Mic92 commented Mar 5, 2019

@GrahamcOfBorg build shotcut

@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

@GrahamcOfBorg eval

@xeji xeji merged commit ed76b08 into NixOS:master Mar 8, 2019
@infinisil infinisil mentioned this pull request Mar 9, 2019
Closed
11 tasks
@infinisil
Copy link
Member

Fix was in mltframework/shotcut#698

srhb pushed a commit that referenced this pull request Apr 7, 2019
@woffs @srhb
shotcut: 18.12.23 -> 19.02.28 (#56875)
30c67ec 
fixes build with qt 5.12, apparently

Backport of #56875
(cherry picked from commit ed76b08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@woffs @Mic92 @xeji @infinisil @GrahamcOfBorg