Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazelisk: init at 0.0.3 #56867

Merged
merged 1 commit into from Mar 25, 2019
Merged

bazelisk: init at 0.0.3 #56867

merged 1 commit into from Mar 25, 2019

Conversation

elasticdog
Copy link
Contributor

@elasticdog elasticdog commented Mar 5, 2019 •
edited

Motivation for this change

The bazelisk wrapper has become a recommended means of managing consistent Bazel versions and testing forward compatibility within the upstream community. I'd love to be able to install it via Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elasticdog elasticdog changed the title bazelisk: init at 0.0.2 bazelisk: init at 0.0.3 Mar 23, 2019
@elasticdog
Copy link
Contributor Author

@uri-canva everything worked great with the switch to buildGoModule. I rebased and pushed those changes, so this should be ready for re-review. There was also a new bazelisk release ~10 days ago, so now this is initializing the package at the latest upstream version.

marsam
marsam reviewed Mar 23, 2019
View reviewed changes
pkgs/development/tools/bazelisk/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/bazelisk/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/bazelisk/default.nix Outdated Show resolved Hide resolved
@kalbasit
Copy link
Member

@GrahamcOfBorg build bazelisk

@kalbasit kalbasit merged commit 1f6e46f into NixOS:master Mar 25, 2019
@kalbasit
Copy link
Member

Thanks!

@elasticdog elasticdog deleted the bazelisk branch March 25, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@uri-canva uri-canva uri-canva left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elasticdog @kalbasit @marsam @uri-canva @GrahamcOfBorg