Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_8: rc2 -> rc3 #56798

Merged
merged 1 commit into from Mar 14, 2019
Merged

llvmPackages_8: rc2 -> rc3 #56798

merged 1 commit into from Mar 14, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 4, 2019

Motivation for this change

cc @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 7, 2019

This is blocking on diagnostic test failure when built w/musl-- initial investigation points to a bug in LLVM that occurs with or without musl (valgrind, hashmap update-while-modifying-and-invalidating bug I think?) but only causes noticeable corruption w/musl.

I haven't had a chance to chase this down, and am kinda hoping whatever it is (the above might not be correct for whatever reason) will be fixed in the next RC.... if it hasn't already O:).

@dtzWill dtzWill merged commit 145f213 into NixOS:master Mar 14, 2019
@dtzWill dtzWill deleted the update/llvm8-rc3 branch March 14, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @matthewbauer @GrahamcOfBorg