Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron{,_3}: updates (fixes, security?) #56799

Merged
merged 3 commits into from Mar 7, 2019
Merged

electron{,_3}: updates (fixes, security?) #56799

merged 3 commits into from Mar 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 4, 2019

Motivation for this change

electron: https://electronjs.org/releases/stable?version=4
electron_3: https://electronjs.org/releases/stable?version=3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 7, 2019

cc @NixOS/backports

@dtzWill dtzWill merged commit 6aa04f0 into NixOS:master Mar 7, 2019
@dtzWill dtzWill deleted the update/electron-2019-02 branch March 7, 2019 20:57
lheckemann pushed a commit that referenced this pull request Mar 8, 2019
@dtzWill @lheckemann
electron: version bumps
0d0bd6d 
(cherry picked from commit 423e3e5)
PR #56799
lheckemann pushed a commit that referenced this pull request Mar 8, 2019
@dtzWill @lheckemann
electron_3: 3.1.3 -> 3.1.4
55a2904 
https://electronjs.org/releases/stable?version=3#3.1.4
(cherry picked from commit 505f2d3)
PR #56799
lheckemann pushed a commit that referenced this pull request Mar 8, 2019
@dtzWill @lheckemann
electron: 4.0.5 -> 4.0.6
0711b73 
https://electronjs.org/releases/stable#release-notes-for-v406
(cherry picked from commit 79b321b)
PR #56799
@lheckemann
Copy link
Member

Backported to 19.03, thanks!

@dtzWill dtzWill mentioned this pull request Mar 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @lheckemann @GrahamcOfBorg