Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: 2018 -> 2018-final #56797

Merged
merged 8 commits into from Mar 12, 2019
Merged

texlive: 2018 -> 2018-final #56797

merged 8 commits into from Mar 12, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 4, 2019

Motivation for this change

It's March, final texlive is out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bhipple

mkUniqueOutPaths used to produce empty paths for dummy packages, this
version strips those out. This does not affect `pkgList.bin` at all, but
`pkgList.nonbin` is affected, so this is not exactly a refactoring. It
should not harm to have a cleaner `paths`.

Also, original comment said "here we deal with those dummy packages
needed for hyphenation filtering". This doesn't seem to be true, the
packages that were really filtered are actually metapackages that
represent collections. I also could not find any dummy packages even in
the originally committed version.
@veprbl veprbl added the 6.topic: TeX Issues regarding texlive and TeX in general label Mar 4, 2019
@veprbl veprbl requested review from vcunat and xeji March 4, 2019 02:55
Initial language.{dat,def} configuration files provided by
`texlive.hyphen-base` may declare languages that were not part of the
combined packages. Those are filtered out by a sed script that had few
problems:

1) The sed script was generated from a list of potentially non-unique
packages. Every repetition of a select and print clause would produce a
copy of a language declaration in the output file. This became a problem
for update to the 2018-final, the fmtutil would crash from too much
German hyphenation.
2) The select clauses were ambiguous: both '^% from hyphen' and
'^% from hyphen-welsh' will match a line 'from hyphen-welsh'.
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Don't have time to test this locally but LGTM. Should be backported to 19.03.

@xeji xeji added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 4, 2019
Biber 2.12 is for biblatex 3.12.
@dotlambda
Copy link
Member

Biber needed an update because according to https://sourceforge.net/projects/biblatex-biber/

Biber 2.12 is for biblatex 3.12

@dotlambda
Copy link
Member

Maybe we should add a comment somewhere to remind people to update Biber whenever biblatex is updated.

@veprbl
Copy link
Member Author

veprbl commented Mar 4, 2019

@dotlambda
How about this for solution?

@dotlambda
Copy link
Member

How about this for solution?

Perfect!

Should we disable Biber's tests on ARM? I have no idea how to solve

Can't load '/nix/store/0wdrvy0yyqzjf20q2m2fw8njbk0c1367-perl5.28.1-Text-BibTeX-0.85/lib/perl5/site_perl/5.28.1/aarch64-linux-thread-multi/auto/Text/BibTeX/BibTeX.so' for module Text::BibTeX: libbtparse.so: cannot open shared object file: No such file or directory at /nix/store/sg676sz2hbjd3vhiq5zgyndbzka59iq1-perl-5.28.1/lib/perl5/5.28.1/aarch64-linux-thread-multi/DynaLoader.pm line 193.

@veprbl
Copy link
Member Author

veprbl commented Mar 5, 2019

Should we disable Biber's tests on ARM?

I would imagine biber needs a working TextBibTeX to operate, so this would probably just break at runtime.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to be merged. Tested locally and everything works fine.

@veprbl veprbl marked this pull request as ready for review March 7, 2019 22:22
@veprbl veprbl merged commit 05edf03 into NixOS:master Mar 12, 2019
@xeji
Copy link
Contributor

xeji commented Mar 12, 2019

backported to 19.03 in 9e762da..734fdd9

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 13, 2019
@vcunat
Copy link
Member

vcunat commented Mar 16, 2019

Perhaps we should change the maintainer field to something closer to the reality? I'm afraid I won't be putting much effort towards TeX stuff anymore (and I wasn't for the past couple of years already).

veprbl added a commit that referenced this pull request Mar 16, 2019
cc #56797

(cherry picked from commit 7669144)
veprbl added a commit that referenced this pull request Mar 16, 2019
@veprbl veprbl deleted the pr/texlive-2018-final branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: TeX Issues regarding texlive and TeX in general 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants