-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
texlive: 2018 -> 2018-final #56797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
texlive: 2018 -> 2018-final #56797
Conversation
mkUniqueOutPaths used to produce empty paths for dummy packages, this version strips those out. This does not affect `pkgList.bin` at all, but `pkgList.nonbin` is affected, so this is not exactly a refactoring. It should not harm to have a cleaner `paths`. Also, original comment said "here we deal with those dummy packages needed for hyphenation filtering". This doesn't seem to be true, the packages that were really filtered are actually metapackages that represent collections. I also could not find any dummy packages even in the originally committed version.
Initial language.{dat,def} configuration files provided by `texlive.hyphen-base` may declare languages that were not part of the combined packages. Those are filtered out by a sed script that had few problems: 1) The sed script was generated from a list of potentially non-unique packages. Every repetition of a select and print clause would produce a copy of a language declaration in the output file. This became a problem for update to the 2018-final, the fmtutil would crash from too much German hyphenation. 2) The select clauses were ambiguous: both '^% from hyphen' and '^% from hyphen-welsh' will match a line 'from hyphen-welsh'.
2ef4de2
to
40f55d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Don't have time to test this locally but LGTM. Should be backported to 19.03.
Biber 2.12 is for biblatex 3.12.
Biber needed an update because according to https://sourceforge.net/projects/biblatex-biber/
|
Maybe we should add a comment somewhere to remind people to update Biber whenever biblatex is updated. |
@dotlambda |
Perfect! Should we disable Biber's tests on ARM? I have no idea how to solve
|
I would imagine biber needs a working TextBibTeX to operate, so this would probably just break at runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to be merged. Tested locally and everything works fine.
Perhaps we should change the |
Motivation for this change
It's March, final texlive is out.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @bhipple