Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkit: move to aliases #56892

Merged
merged 1 commit into from Mar 5, 2019
Merged

webkit: move to aliases #56892

merged 1 commit into from Mar 5, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar referenced this pull request in NixOS/cabal2nix Mar 5, 2019
@peti
Update name mapping and resolver lists to cope with disappeared aliases.
5012521 
See #411 (comment) and
following comments for details.
peti
peti reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual changes to haskell-packages.nix are problematic. We need a process that ensures that subsequent runs of hackage2nix will not undo those changes. The best way to accomplish that is to make the necessary modifications in cabal2nix first and then to re-generate that file by actually running hackage2nix.

jtojnar added a commit to jtojnar/cabal2nix that referenced this pull request Mar 5, 2019
@jtojnar
Update mapping of webkitgtk to non-aliased version
c7ccb0a 
This is in preparation of NixOS/nixpkgs#56892

javascriptcoregtk-4.0 and webkit2gtk-web-extension-4.0 are also part of the webkitgtk package.
@jtojnar jtojnar mentioned this pull request Mar 5, 2019
Merged
@jtojnar jtojnar merged commit d3ff902 into NixOS:master Mar 5, 2019
@jtojnar jtojnar deleted the webkit-no-aliases branch June 15, 2019 15:51
Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this pull request Mar 7, 2022
@jtojnar @Profpatsch
Update mapping of webkitgtk to non-aliased version
ffa8440 
This is in preparation of NixOS/nixpkgs#56892

javascriptcoregtk-4.0 and webkit2gtk-web-extension-4.0 are also part of the webkitgtk package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @peti @GrahamcOfBorg