Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arpack: 3.6.3 -> 3.7.0 #56891

Merged
merged 2 commits into from Apr 3, 2019
Merged

arpack: 3.6.3 -> 3.7.0 #56891

merged 2 commits into from Apr 3, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Mar 5, 2019 •
edited

Motivation for this change

Regular update. Did require some manual work.

Changelog: https://github.com/opencollab/arpack-ng/blob/master/CHANGES

CC @ttuegel

Things done
  • switch to FetchFromGitHub
  • switch from autotools to cmake
  • add eigen to input (is now required)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member Author

markuskowa commented Mar 30, 2019 •
edited

@GrahamcOfBorg build arpack
@GrahamcOfBorg build octopus
@GrahamcOfBorg build octave
@GrahamcOfBorg build julia

@markuskowa
Copy link
Member Author

octave and julia build locally.

@markuskowa
arpack: 3.6.3 -> 3.7.0
9a60a65 
* switch to FetchFromGitHub
* switch from autotools to cmake
* add eigen to input (is now required)
@markuskowa
arpack: fix tests on darwin
70867a9
@markuskowa
Copy link
Member Author

rebased onto master

@markuskowa markuskowa merged commit 30c081e into NixOS:master Apr 3, 2019
@markuskowa markuskowa deleted the upd-arpack branch April 3, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @infinisil @GrahamcOfBorg