Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.bpython: correct Exec in bpython.desktop #56872

Merged
merged 1 commit into from Mar 5, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes #56831

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Soft

@dotlambda dotlambda requested a review from FRidh as a code owner March 5, 2019 09:32
@FRidh
Copy link
Member

FRidh commented Mar 5, 2019

We could use a patchDesktops command, like patchShebangs.

@dotlambda
Copy link
Member Author

dotlambda commented Mar 5, 2019

We could use a patchDesktops command, like patchShebangs.

I can't find such a script. Can you point me to the implementation or an example usage?

@FRidh
Copy link
Member

FRidh commented Mar 5, 2019

patchShebangs is implemented in pkgs/build-support/setup-hooks/patch-shebangs.sh

@dotlambda
Copy link
Member Author

I misunderstood you. I thought you meant patchDesktops already existed. Indeed, such a script would be nice to have.

@flokli flokli merged commit 1aa0980 into NixOS:master Mar 5, 2019
@flokli
Copy link
Contributor

flokli commented Mar 5, 2019

19.03 backport in ae84bf1, 18.09 backport in ed8c74e.

@dotlambda dotlambda deleted the bpython-desktop-file branch March 21, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bpython desktop-file references /usr/bin/bpython
4 participants