nixos/nixos-install: tell the user what to do if setting a root password failed #56790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
improve-error-handling-for-nixos-install
branch
from
6290a3f
to
81c8740
Compare
grahamc
reviewed
Mar 3, 2019
Ma27
force-pushed
the
improve-error-handling-for-nixos-install
branch
from
81c8740
to
67c1e98
Compare
|
@grahamc anything else to add? :) |
matthewbauer
approved these changes
Mar 7, 2019
infinisil
reviewed
Mar 7, 2019
|
I think we should backport this one. |
Ma27
force-pushed
the
improve-error-handling-for-nixos-install
branch
from
67c1e98
to
9e1d174
Compare
|
@infinisil fixed. |
infinisil
approved these changes
Mar 8, 2019
|
Oh and I guess the commit message should be |
…ord failed If setting a root password using the `passwd` call in the `nixos-install` script fails, it should be explained how set it manually to ensure that nobody gets accidentally locked out of the system.
Ma27
force-pushed
the
improve-error-handling-for-nixos-install
branch
from
9e1d174
to
eaf98c7
Compare
Ma27
changed the title
|
@infinisil fixed. And thanks for the review! |
|
@lheckemann @samueldr I consider this patch a candidate for backporting. As it touches the NixOS installer, I'm rather hesitant to backport without a review of at least one of you :) |
|
Talked to @lheckemann in person yesterday he told me to go for it with the backport. Now backported as ed21cf9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
If setting a root password using the
passwdcall in thenixos-installscript fails, it should be explained how set it manuallyto ensure that nobody gets accidentally locked out of the system.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)