Skip to content

nixos/nixos-install: tell the user what to do if setting a root password failed #56790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

nixos/nixos-install: tell the user what to do if setting a root password failed #56790

merged 1 commit into from
Mar 8, 2019
+12 −1

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 3, 2019 •
edited
Loading

Motivation for this change

If setting a root password using the passwd call in the
nixos-install script fails, it should be explained how set it manually
to ensure that nobody gets accidentally locked out of the system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ma27 Ma27 requested a review from infinisil as a code owner March 3, 2019 20:10
@Ma27 Ma27 force-pushed the improve-error-handling-for-nixos-install branch from 6290a3f to 81c8740 Compare March 3, 2019 20:12
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 3, 2019
@Ma27 Ma27 force-pushed the improve-error-handling-for-nixos-install branch from 81c8740 to 67c1e98 Compare March 4, 2019 00:42
@Ma27
Copy link
Member Author

Ma27 commented Mar 5, 2019

@grahamc anything else to add? :)

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

I think we should backport this one.

@Ma27 Ma27 force-pushed the improve-error-handling-for-nixos-install branch from 67c1e98 to 9e1d174 Compare March 8, 2019 17:26
@Ma27
Copy link
Member Author

Ma27 commented Mar 8, 2019

@infinisil fixed.
@Mic92 I intended to ask the RMs as soon as this is merged :)

@infinisil
Copy link
Member

Oh and I guess the commit message should be nixos/nixos-install: ... by convention

@Ma27
nixos/nixos-install: tell the user what to do if setting a root passw…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
eaf98c7 
…ord failed

If setting a root password using the `passwd` call in the
`nixos-install` script fails, it should be explained how set it manually
to ensure that nobody gets accidentally locked out of the system.
@Ma27 Ma27 force-pushed the improve-error-handling-for-nixos-install branch from 9e1d174 to eaf98c7 Compare March 8, 2019 18:57
@Ma27 Ma27 changed the title nixos-install: tell the user what to do if setting a root password failed nixos/nixos-install: tell the user what to do if setting a root password failed Mar 8, 2019
@Ma27
Copy link
Member Author

Ma27 commented Mar 8, 2019

@infinisil fixed. And thanks for the review!

@infinisil infinisil merged commit a951828 into NixOS:master Mar 8, 2019
@Ma27 Ma27 deleted the improve-error-handling-for-nixos-install branch March 8, 2019 20:12
@Ma27
Copy link
Member Author

Ma27 commented Mar 9, 2019

@lheckemann @samueldr I consider this patch a candidate for backporting. As it touches the NixOS installer, I'm rather hesitant to backport without a review of at least one of you :)

@Ma27
Copy link
Member Author

Ma27 commented Mar 14, 2019

Talked to @lheckemann in person yesterday he told me to go for it with the backport. Now backported as ed21cf9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

@matthewbauer matthewbauer

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @Mic92 @infinisil @matthewbauer @grahamc @GrahamcOfBorg