openafs: Add support for Linux 5.0 to openafs_1_8 #56859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAFS 1.8.2 does has not yet merged support for Linux 4.20 or 5.0 This patch cherry-picks commits from the git repository, and includes them in the patches/ directory. This also replaces the amalgamated Linux 4.20 patches I added earlier with the original outputs from `git show`. This has been tested to build on Linux 4.4, 4.14, 4.20, and 5.0. This does not change the derivations of openafs_1_8, only linuxPackages_*.openafs_1_8.
|
cc @spacefrogg |
|
@GrahamcOfBorg build linuxPackages_5_0.openafs_1_8 Edit, oops, I can't do this. Can someone else run this for me? |
|
@artemist You might need to add yourself to known-users by opening a PR against https://github.com/NixOS/ofborg @GrahamcOfBorg build linuxPackages_5_0.openafs_1_8 |
veprbl
reviewed
Mar 5, 2019
|
@GrahamcOfBorg build linuxPackages_5_0.openafs_1_8 |
|
I can remove the patches from the new directory I created like I did in #56862, although IMHO it looks cleaner with all 3 patches in a directory (it was cleaner without the dir with 1.6 though) |
Mic92
changed the title
|
Looks good to me. I have no particular opinion on going with or without a patches/ directory. |
veprbl
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
Works. Most kernels build:
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.openafs_1_8 linuxPackages_hardkernel_latest.openafs_1_8
4 package failed to build:
linuxPackages_hardened.openafs_1_8 linuxPackages_latest-libre.openafs_1_8
linuxPackages_latest_hardened.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8
10 package were build:
linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_19.openafs_1_8
linuxPackages_4_20.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8
linuxPackages_5_0.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8
linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
OpenAFS 1.8.2 does has not yet merged support for Linux 4.20 or 5.0
Things done
This patch cherry-picks commits from the git repository, and includes
them in the patches/ directory. This also replaces the amalgamated Linux 4.20
patches I added earlier with the original outputs from
git show.This has been tested to build on Linux 4.4, 4.14, 4.20, and 5.0.
This does not change the derivations of openafs_1_8, only
linuxPackages_*.openafs_1_8.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)