Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: 0.30.0 -> 0.35.0 #56879

Merged
merged 2 commits into from Mar 8, 2019
Merged

minikube: 0.30.0 -> 0.35.0 #56879

merged 2 commits into from Mar 8, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 5, 2019 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to latest version (k8s bump to 1.13.2)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
minikube: 0.30.0 -> 0.34.1
5a33fea 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
minikube: 0.34.1 -> 0.35.0
765fdd9 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester changed the title minikube: 0.30.0 -> 0.34.1 minikube: 0.30.0 -> 0.35k0 Mar 7, 2019
@vdemeester vdemeester changed the title minikube: 0.30.0 -> 0.35k0 minikube: 0.30.0 -> 0.35.0 Mar 7, 2019
@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

@GrahamcOfBorg build minikube docker-machine-kvm2

@xeji xeji merged commit 1f037a9 into NixOS:master Mar 8, 2019
@vdemeester vdemeester deleted the update-minikube branch March 9, 2019 08:07
fpletz pushed a commit that referenced this pull request Apr 2, 2019
@vdemeester @fpletz
minikube: 0.30.0 -> 0.35.0 (#56879)
4151cc0 
* minikube: 0.30.0 -> 0.34.1

Signed-off-by: Vincent Demeester <vincent@sbr.pm>

* minikube: 0.34.1 -> 0.35.0

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
(cherry picked from commit 1f037a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @xeji @GrahamcOfBorg