Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bash: fix root prompt #56880

Merged
merged 1 commit into from Mar 8, 2019
Merged

Conversation

lheckemann
Copy link
Member

Motivation for this change

b4b6717 introduced a regression of
its own: the prompt would end with $ for all users, not with # for
root as it should.

This should be backported to 19.03, and I'll do so when it's merged (unless the merger beats me to it!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

b4b6717 introduced a regression of
its own: the prompt would end with $ for all users, not with # for
root as it should.
@infinisil
Copy link
Member

@GrahamcOfBorg eval

@infinisil
Copy link
Member

Cherry-picked to 19.03 in 37b1058 :)

@lheckemann lheckemann deleted the bash-root-prompt-fix branch March 8, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants