Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sile: build and install documentation (self test) #56873

Merged
merged 1 commit into from Mar 7, 2019
Merged

sile: build and install documentation (self test) #56873

merged 1 commit into from Mar 7, 2019

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Mar 5, 2019

Motivation for this change

Documentation and tests for Sile was missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa self-requested a review March 5, 2019 15:35
@markuskowa markuskowa self-assigned this Mar 5, 2019
@markuskowa
Copy link
Member

@GrahamcOfBorg eval

markuskowa
markuskowa reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the fonts could be mentioned in the commit message.

@ck3d
Copy link
Contributor Author

ck3d commented Mar 5, 2019

Thanks. I added a note to explain the addition of fonts.

@markuskowa
Copy link
Member

@GrahamcOfBorg build sile

@markuskowa
Copy link
Member

markuskowa commented Mar 7, 2019 •
edited

@GrahamcOfBorg build sile

@ck3d
sile: build and install documentation (self test)
b084085 
- added primary fonts (some non free fonts are missing, but sile selects
  alternative fonts) used by documentation
@markuskowa markuskowa merged commit 7f96a9f into NixOS:master Mar 7, 2019
@teto teto mentioned this pull request Jan 15, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

Assignees

@markuskowa markuskowa

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @markuskowa @GrahamcOfBorg