Hmm ... are draft PRs only for "work in progress"? I'll turn it into an actual PR, then, as I haven't any changes planned before review.

@GrahamcOfBorg build ili2c

oops. I guess I refactored rev after fixing the hash. Will update the branch with a fix.

@GrahamcOfBorg build ili2c

https://github.com/NixOS/nixpkgs/pull/56893/checks?check_run_id=84891442

Why does aarch64-linux default to the unfree Oracle JDK instead of (like the other NixOS platforms) to the free OpenJDK?

https://github.com/NixOS/nixpkgs/pull/56893/checks?check_run_id=84891499

And what's going on in the x86_64-darwin build? "BUILD SUCCESSFUL", but resulting jar file missing? How comes? (Is it looking in the right directory? /private/tmp/nix-build-ili2c-4.7.11.drv-0/source/build/jar/ili2c.jar might not be the same location as /build/source/build/jar/ili2c.jar, is/should it?)

Can someone more experienced advise, please?

@das-g see #35510 for the reason why aarch64 gets oraclejdk.

@das-g Are you able to continue with this PR?

@das-g Are you able to continue with this PR?

I think I can, though I'm not sure whether I should continue and if so, how.

cross-release building broken

When built on a NixOS 18.03 system, running the result currently fails. I suspect that's due to #54278. When this change is applied on the release-18.09 branch (currently 95fed28) the resulting build result seems to work fine.

On 19.03, this doesn't seem to be an issue anymore. 👍

Can someone comment on these two questions?

Does this even belong here?

I'm not sure whether this software has a wide enough audience to be included in NixPkgs, or whether it should (for now) live in an overlay or in NUR.

Does this belong there?

"misc." categories always have the tendency to grow uncontrollably. Maybe it's time for a GIS subfolder in the pkgs tree?

If the answer to both is "yes" (i.e., it does belong in NixPkgs and should be in pkgs/tools/misc/), how should I proceed? Upstream has released Version 5.0.0, but I guess NixPkgs could upgrade to that in a later PR. Should I rebase on current nixpkgs master? What else needs to be done?

And does something need to be done about aarch64-linux and x86_64-darwin? If so, what?

Does this even belong here?

I've seen some very domain specific software packaged and accepted in NixOS. I don't see any reason this can't be included.

Upstream has released Version 5.0.0

I would suggest you update this PR to init at 5.0.0

does something need to be done about aarch64-linux and x86_64-darwin?

aarch64-linux won't evaluate by the bot because it uses non-free java, so unless you have reason to believe it won't work just ignore that. x86_64-darwin is marked as failure so you could either fix that, or adjust your platforms to exclude it.

(The force push from 2aaa887 to e744ea3 is just a re-base on master, so you can ignore that.)

@GrahamcOfBorg build ili2c

@das-g Can you please fix the darwin issue if you have the ability to, or update platforms accordingly?

@das-g Can you please fix the darwin issue if you have the ability to, or update platforms accordingly?

(I didn't update platforms in the previous changes to this PR, because I speculated it might work by now, be it due to changes to NixPkgs, due to the change to ili2c 5.0.0 or changes to the automated build infrastructure that might have happened since the build attempt before that.)

Changed to linux-only with https://github.com/NixOS/nixpkgs/compare/e744ea36c228bfba184df3977849885a811eb819..c8c751aca277ae4c2f3de5efd32493d8095a819e

I'd like to have it work for all platforms and think that should be possible for a pure-Java application like this seems to be. However I don't have any device with macOS so I cannot examine the build locally, and I have no idea what goes wrong there. (It seems to look for the JAR in a different directory than where it built it, but why?)

Thanks @das-g!

Thank you, @aanderse, for your guidance! 😃