pythonPackages.isort: 4.3.4 -> 4.3.15 #56884

kwohlfahrt · 2019-03-05T14:03:54Z

We set $TMPDIR, because isort refuses to run in paths containing
'build' (since that is part of Python's typical build infrastructure).

Motivation for this change

Version bump.

Things done

xeji · 2019-03-08T22:27:22Z

@GrahamcOfBorg eval

pkgs/development/python-modules/isort/default.nix

dotlambda · 2019-03-23T11:18:14Z

pkgs/top-level/python-packages.nix

@@ -2893,7 +2893,7 @@ in {

  iso8601 = callPackage ../development/python-modules/iso8601 { };

-  isort = callPackage ../development/python-modules/isort {};
+  isort = disabledIf (!isPy3k) (callPackage ../development/python-modules/isort {});


This should be put inside the expression: disabled = !isPy3k. However, I don't think we can afford to drop Python 2 support right now.

Actually, I don't see any hint at isort only supporting Python 3. Do you?

This was in the release notes a while back: https://github.com/timothycrosley/isort/releases/tag/4.3.5

It might still work from coincidence, so I can switch it on again? AFAIK isort is mostly used as a CLI application, so it doesn't really matter what python version it supports.

Why do some packages use callPackage ./whatever.nix { disabled = isPy3k; }, and some use disabledIf isPy3k (callPackage ./whatever.nix)? protobuf uses the former, zeitgeist uses the latter.

The latter is only there because it has been for some time. It should no longer be used.

The reason that we cannot simply drop Python 2 support is that there is quite a number of packages that depend on isort or pytest-isort. What you could do is use

isort = if isPy3k then callPackage ... { } else callPackage ... { };

Ah, OK. So I should pin the old version for use in python 2?

Wait, only protobuf uses the disabled = ... syntax, everything else uses disabledIf - or am I missing something?

Ah, OK. So I should pin the old version for use in python 2?

Yes, please use the latest version with Python 2 support for that.

Wait, only protobuf uses the disabled = ... syntax, everything else uses disabledIf - or am I missing something?

grep -r "disabled =" pkgs/development/python-modules/ yields quite a lot of results.

Even though we now have two expressions, please do still add disabled = !isPy3k to default.nix.

Ah, I was looking in top-level/python-packages.nix. Done.

pkgs/development/python-modules/isort/4_3_5.nix

dotlambda

There should be two commits with the following commit messages:

pythonPackages.isort: 4.3.4 -> 4.3.16
pythonPackages.isort: pin python2-compatible version

kwohlfahrt · 2019-03-25T14:25:39Z

Squashed, added link and disabled attribute.

dotlambda · 2019-03-25T14:28:45Z

Please mind the pythonPackages. prefix that should be added to commit messages when it comes to Python packages.

dotlambda · 2019-03-25T14:29:32Z

The tests for the Python 2 variant are failing:

@GrahamcOfBorg build python2.pkgs.isort

dotlambda · 2019-03-25T14:33:51Z

Strange, I got

builder for '/nix/store/cm8qmxfbl5b96wjmn08pkgb76kxcby1n-python2.7-pytest-isort-0.3.1.drv' failed with exit code 1; last 10 log lines:
  E           and: u'=========================== 1 passed in 0.02 seconds ==========================='
  E           and: u''
  E       remains unmatched: '*test_incorrectly_sorted*FAILED*'
  
  /build/pytest-isort-0.3.1/test_isort.py:123: Failed
  ========================== deprecated python version ===========================
  You are using Python 2.7.15, which will no longer be supported in pytest 5.0
  For more information, please read:
    https://docs.pytest.org/en/latest/py27-py34-deprecation.html
  ====================== 1 failed, 8 passed in 0.85 seconds ======================

locally. Still investigating why.

dotlambda · 2019-03-25T14:41:11Z

Ah I see. That's pytest-isort :D My fault.
Still, we'll have to investigate that because it would cause much breakage.

kwohlfahrt · 2019-03-26T11:43:01Z

Weirdly, rolling back to 4.3.4 for python 2 doesn't work - the same test still fails:

  version = "4.3.4";

  src = fetchPypi {
    inherit pname version;
    sha256 = "1y0yfv56cqyh9wyg7kxxv9y5wmfgcq18n7a49mp7xmzka2bhxi5r";
  };

dotlambda · 2019-03-26T12:04:12Z

I just came across PyCQA/isort#904. So there's no need to use a different version for Python 2.

kwohlfahrt · 2019-03-26T12:41:49Z

Removed python-2 specific version. There was a failing test, but for some reason it is passing in upstream CI, so I haven't dug into it much.

pkgs/development/python-modules/isort/default.nix

pkgs/top-level/python-packages.nix

We set $TMPDIR, because isort refuses to run in paths containing 'build' (since that is part of Python's typical build infrastructure).

kwohlfahrt · 2019-03-26T13:31:49Z

Addressed all comments.

dotlambda · 2019-03-26T13:43:06Z

@GrahamcOfBorg build python2.pkgs.pytest-isort python3.pkgs.pytest-isort

dotlambda · 2019-03-26T13:47:17Z

Nice, it works! 🎉
Thanks a lot for bearing with me @kwohlfahrt!

The isort tests were broken after upgrading the isort package.

dotlambda · 2019-03-26T13:59:09Z

This broke cssselect2, so I disabled the useless tests.

kwohlfahrt · 2019-03-26T15:17:04Z

Yay! Thanks for looking after this PR - isort was incompatible with black before (i.e. they'd revert each other's changes) so it's nice to have this in.

kwohlfahrt requested a review from FRidh as a code owner March 5, 2019 14:03

GrahamcOfBorg added the 6.topic: python label Mar 5, 2019

GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Mar 8, 2019

kwohlfahrt changed the title ~~isort: 4.3.4 -> 4.3.10~~ isort: 4.3.4 -> 4.3.15 Mar 19, 2019

dotlambda reviewed Mar 23, 2019

View reviewed changes

pkgs/development/python-modules/isort/default.nix Outdated Show resolved Hide resolved

dotlambda reviewed Mar 23, 2019

View reviewed changes

dotlambda changed the title ~~isort: 4.3.4 -> 4.3.15~~ pythonPackages.isort: 4.3.4 -> 4.3.15 Mar 23, 2019

kwohlfahrt force-pushed the isort branch 2 times, most recently from 6852fe9 to b99007c Compare March 25, 2019 13:07

dotlambda reviewed Mar 25, 2019

View reviewed changes

pkgs/development/python-modules/isort/4_3_5.nix Outdated Show resolved Hide resolved

kwohlfahrt force-pushed the isort branch from 6f77b8d to e4660cb Compare March 25, 2019 14:21

dotlambda requested changes Mar 25, 2019

View reviewed changes

kwohlfahrt force-pushed the isort branch 2 times, most recently from 4435e8b to f23d4c6 Compare March 25, 2019 14:25

kwohlfahrt force-pushed the isort branch 2 times, most recently from 3b3e6dd to 74a8b9a Compare March 26, 2019 12:41

dotlambda reviewed Mar 26, 2019

View reviewed changes

pkgs/development/python-modules/isort/default.nix Outdated Show resolved Hide resolved

dotlambda reviewed Mar 26, 2019

View reviewed changes

pkgs/development/python-modules/isort/default.nix Outdated Show resolved Hide resolved

dotlambda reviewed Mar 26, 2019

View reviewed changes

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved

pythonPackages.isort: 4.3.4 -> 4.3.16

f61ed7f

We set $TMPDIR, because isort refuses to run in paths containing 'build' (since that is part of Python's typical build infrastructure).

kwohlfahrt force-pushed the isort branch from 74a8b9a to f61ed7f Compare March 26, 2019 13:30

python.pkgs.cssselect2: no isort etc. tests

6dac4d5

The isort tests were broken after upgrading the isort package.

dotlambda merged commit 4ad9324 into NixOS:master Mar 26, 2019

kwohlfahrt deleted the isort branch March 27, 2019 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.isort: 4.3.4 -> 4.3.15 #56884

pythonPackages.isort: 4.3.4 -> 4.3.15 #56884

kwohlfahrt commented Mar 5, 2019

xeji commented Mar 8, 2019

dotlambda Mar 23, 2019

dotlambda Mar 23, 2019

kwohlfahrt Mar 25, 2019

kwohlfahrt Mar 25, 2019

dotlambda Mar 25, 2019

kwohlfahrt Mar 25, 2019

kwohlfahrt Mar 25, 2019

dotlambda Mar 25, 2019

dotlambda Mar 25, 2019

kwohlfahrt Mar 25, 2019

dotlambda left a comment

kwohlfahrt commented Mar 25, 2019

dotlambda commented Mar 25, 2019

dotlambda commented Mar 25, 2019 •

edited

dotlambda commented Mar 25, 2019 •

edited

dotlambda commented Mar 25, 2019

kwohlfahrt commented Mar 26, 2019

dotlambda commented Mar 26, 2019

kwohlfahrt commented Mar 26, 2019

kwohlfahrt commented Mar 26, 2019

dotlambda commented Mar 26, 2019

dotlambda commented Mar 26, 2019

dotlambda commented Mar 26, 2019

kwohlfahrt commented Mar 26, 2019

pythonPackages.isort: 4.3.4 -> 4.3.15 #56884

pythonPackages.isort: 4.3.4 -> 4.3.15 #56884

Conversation

kwohlfahrt commented Mar 5, 2019

Motivation for this change

Things done

xeji commented Mar 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda left a comment

Choose a reason for hiding this comment

kwohlfahrt commented Mar 25, 2019

dotlambda commented Mar 25, 2019

dotlambda commented Mar 25, 2019 • edited

dotlambda commented Mar 25, 2019 • edited

dotlambda commented Mar 25, 2019

kwohlfahrt commented Mar 26, 2019

dotlambda commented Mar 26, 2019

kwohlfahrt commented Mar 26, 2019

kwohlfahrt commented Mar 26, 2019

dotlambda commented Mar 26, 2019

dotlambda commented Mar 26, 2019

dotlambda commented Mar 26, 2019

kwohlfahrt commented Mar 26, 2019

dotlambda commented Mar 25, 2019 •

edited

dotlambda commented Mar 25, 2019 •

edited