Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] filezilla: 3.31.0 -> 3.40.0, libfilezilla: 0.13.0 -> 0.15.1 #56883

Closed
wants to merge 4 commits into from
Closed

[WIP] filezilla: 3.31.0 -> 3.40.0, libfilezilla: 0.13.0 -> 0.15.1 #56883

wants to merge 4 commits into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Mar 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The filezilla project has migrated their source away from sourceforge, so the source is now pulled from their subversion repo. This also required some additional preparation with the auto*-tools.
The download link to their current source code uses some changing hash and timestamp, so it's probably unreliable.

Important: I've only verified these changes against release-18.09 and it's working for me.
Building against master and the new release-19.03 branch results in SIGSEGV when starting filezilla, which I believe is due to some incompatible mixing of the building and running gtk libraries, with similar output as observed in #56832

@tokudan
Copy link
Contributor Author

tokudan commented Mar 5, 2019

@pSub @jokogr Would you be able to check if this works on master or release-19.03?

@jokogr
Copy link
Contributor

jokogr commented Mar 5, 2019

@tokudan this is not working for me, I'm getting assertion failures, e.g.:

./src/gtk/bitmap.cpp(982): assert "IsOk()" failed in GetSubBitmap(): invalid bitmap

If I untick "Show this dialog" and click "Continue", the main window seems OK, but try clicking the Session Manager: it would segfault.

@tokudan tokudan changed the title filezilla: 3.31.0 -> 3.40.0, libfilezilla: 0.13.0 -> 0.15.1 [WIP] filezilla: 3.31.0 -> 3.40.0, libfilezilla: 0.13.0 -> 0.15.1 Mar 5, 2019
@tokudan
Copy link
Contributor Author

tokudan commented Mar 5, 2019

Ok, good to know that it's breaking somewhere else as well.
On release-18.09 with these patches, it seems to be working fine.

I probably won't be able to work on master or release-19.03 till it's matured a bit, so I'll leave this for now and will come back later in a couple of weeks. If someone wants to pick it up in the meantime, feel free.

@jokogr
Copy link
Contributor

jokogr commented Mar 5, 2019

@tokudan I could push my changes here or start a new PR, let me know if it is OK to edit your PR commits.

The changes simplify things quite, but FileZilla still segfaults. I forgot to add the last message I see once it segfaults:

/nix/store/h6f31s0hlf8kp10ji4pgfxblh59cy97v-wxwidgets-3.0.4/include/wx-3.0/wx/object.h(160): assert "wxDynamicCast(ptr, T)" failed in wxCheckCast(): wxStaticCast() used incorrectly

@tokudan
Copy link
Contributor Author

tokudan commented Mar 5, 2019

@jokogr I don't mind if you hijack this PR, I wont get to work on 19.03 or master soon.
If you use this PR or create a new one is up to you, I'm fine with both.

@GrahamcOfBorg GrahamcOfBorg requested a review from pSub March 5, 2019 15:20
@jokogr
Copy link
Contributor

jokogr commented Mar 5, 2019

OK, my commits are mostly cleaning things up:

  • Switched back to fetchurl
  • For these source files there is no need for autoreconf
  • Move some dependencies to nativeBuildInputs or remove them totally
  • Add configure flag --disable-autoupdatecheck to FileZilla
  • Set enableParallelBuilding to true
  • Get gtk through wxGTK30

Unfortunately it has still assertion failures and it segfaults whenever Session Manager pops up.

A quick FileZilla code finds wxStaticCast in src/dbus/wxdbusconnection.h, not sure if it is related to the segfault.

@jokogr
Copy link
Contributor

jokogr commented Mar 5, 2019

cc @peterhoeg in case he has the solution already

@jokogr
Copy link
Contributor

jokogr commented Jun 16, 2019

Filezilla 3.42.1 is already on master, let's close this :)

@jokogr jokogr closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tokudan @jokogr @infinisil @GrahamcOfBorg