Improove robustness of IRC messages #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For python2 it's not really clear that one have to use unicode while IRC is a byte protocol. This might end up in TypeError exceptions. Now both is supported and automatically encoded in the specified encoding.
prologic
approved these changes
Jan 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=========================================
Coverage ? 74.57%
=========================================
Files ? 74
Lines ? 6664
Branches ? 0
=========================================
Hits ? 4970
Misses ? 1694
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python2 it's not really clear that one have to use unicode while IRC
is a byte protocol. This might end up in TypeError exceptions.
Now both is supported and automatically encoded in the specified
encoding.