Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.kconfiglib: init at 10.36.0 #54537

Merged
merged 1 commit into from Aug 18, 2019
Merged

Conversation

teto
Copy link
Member

@teto teto commented Jan 24, 2019

python library to deal with kernel Kconfig system.

Motivation for this change

hopefully we can use this library to generate proper kernel configurations, like enabling an option will enable all the required configs to enable it (while this currently has to be done manually).

As a reference, there seems to be some code on how to achieve this here

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/Kconfiglib/default.nix Outdated Show resolved Hide resolved
sha256 = "0dzdak70ss56n68qssxi9fi9b55y36wj3xiph5y7dw7dbjqax9fi";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests expect to be run from an out of tree folder. Then I got scared it would lead me to a whole lot of trouble with kernel interactions. I might have a look at this in a future update.

pkgs/development/python-modules/Kconfiglib/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/Kconfiglib/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/Kconfiglib/default.nix Outdated Show resolved Hide resolved
@dotlambda dotlambda changed the title python3Packages.Kconfiglib: init at 10.36.0 python3Packages.kconfiglib: init at 10.36.0 Jan 24, 2019
@dotlambda dotlambda changed the title python3Packages.kconfiglib: init at 10.36.0 pythonPackages.kconfiglib: init at 10.36.0 Jan 24, 2019
python library to deal with kernel Kconfig system.
@teto
Copy link
Member Author

teto commented Jan 25, 2019

that should be ok. I just haven't done the tests but as what I did for other packages, I tend to add the tests on subsequent updates.

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Are there any updates on this pull request, please?

@FRidh FRidh merged commit de8c33e into NixOS:master Aug 18, 2019
@teto teto deleted the kconfiglib branch September 5, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants