Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ganttproject-bin from 2.7.2 to 2.8.10 #54536

Merged
merged 4 commits into from Mar 6, 2019
Merged

Update ganttproject-bin from 2.7.2 to 2.8.10 #54536

merged 4 commits into from Mar 6, 2019

Conversation

vidbina
Copy link
Contributor

@vidbina vidbina commented Jan 24, 2019

Motivation for this change

I'm starting to use GanttProject and needed the latest update, then I also added a configuration option for anti-aliasing because I'm on a high-res display but don't want to force everyone to deal with AA as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vidbina vidbina changed the title Update ganttproject to 2.8.9 Update ganttproject-bin from 2.7.2 to 2.8.9 and add anti-aliasing option Jan 24, 2019
@vidbina vidbina force-pushed the update-ganttproject-to-2.8.9 branch from c70b0ac to a2f3b86 Compare March 6, 2019 12:42
@vidbina
ganttproject-bin: enable anti-aliasing by default
6932d93 
On my setup the GUI text is anti-aliased. Since I have a hi-res display
it works quite well for me but since I can imagine that other user may
not want anti-aliasing on their machines (perhaps because they have
lower-res displays) and can override the javaOptions array to control
this behavior.
@vidbina vidbina force-pushed the update-ganttproject-to-2.8.9 branch from e096057 to 6932d93 Compare March 6, 2019 13:11
@vidbina vidbina changed the title Update ganttproject-bin from 2.7.2 to 2.8.9 and add anti-aliasing option Update ganttproject-bin from 2.7.2 to 2.8.10 Mar 6, 2019
@Mic92 Mic92 merged commit 4cb5200 into NixOS:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vidbina @Mic92 @GrahamcOfBorg