Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.10.8 and 1.11.5 #54535

Merged
merged 2 commits into from Jan 31, 2019
Merged

Go 1.10.8 and 1.11.5 #54535

merged 2 commits into from Jan 31, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build go_1_10 go_1_11

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2019

@GrahamcOfBorg eval

@Mic92 Mic92 added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 24, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 24, 2019

@GrahamcOfBorg build go_1_10 go_1_11

@rvolosatovs
Copy link
Member Author

@grahamc NixOS/ofborg#299 was merged 10 days ago, but it seems that still no automated builds get executed by @GrahamcOfBorg and neither can I manually trigger builds(as I tried in e.g. #54535 (comment)). Am I doing something wrong or is the configuration simply still not updated?

@rvolosatovs
Copy link
Member Author

Any update? This is taking too long for what it is, especially considering that having outdated go versions in nixpkgs represent a security issue

@Mic92 Mic92 merged commit e3f9841 into NixOS:master Jan 31, 2019
@vcunat
Copy link
Member

vcunat commented Jan 31, 2019

Well, just for the record, we already had the new versions in master and thus this merge made no difference on the files ;-) The relevant PR: #54658, I didn't notice this one until now.

@grahamc
Copy link
Member

grahamc commented Feb 1, 2019

@rvolosatovs looks like the builds did work? https://github.com/NixOS/nixpkgs/pull/54535/checks

@rvolosatovs
Copy link
Member Author

@grahamc yes, but they were triggered by #54535 (comment)
Not #54535 (comment) or #54535 (comment)

@rvolosatovs rvolosatovs deleted the update/go branch February 2, 2019 12:42
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
1.severity: security 6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rvolosatovs @Mic92 @vcunat @grahamc @GrahamcOfBorg @TredwellGit