Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googleearth: adding application launcher and icons #54527

Merged
merged 1 commit into from Jan 25, 2019

Conversation

fusion809
Copy link
Contributor

@fusion809 fusion809 commented Jan 24, 2019

I am adding an application launcher (desktop configuration file) and icons to the appropriate locations in the share/ directory for the googleearth package. I am merely using those already in opt/, with the only modification being made to them being to make the Exec= line in the desktop configuration file point to the correct executable for the program.

Motivation for this change

Presently the googleearth package provides no application launcher, so the only way to start it is by manually executing googleearth as a command. In this PR I am rectifying this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fusion809
Copy link
Contributor Author

Better CC the maintainer, @markus1189.

@fusion809 fusion809 force-pushed the patch-9 branch 2 times, most recently from d2eea24 to 97a1d3f Compare January 24, 2019 03:48
@fusion809 fusion809 changed the title googleearth: adding application launcher and icon googleearth: adding application launcher and icons Jan 24, 2019
@markus1189
Copy link
Contributor

Sounds good! Can't test this because I don't have a desktop environment ;)

@fusion809
Copy link
Contributor Author

What about with Rofi? Rofi will show you it.

@markus1189
Copy link
Contributor

But rofi does only scan PATH and show me the regular googleearth executable unless there is a mode I don't know

@fusion809
Copy link
Contributor Author

Well, for me I use:

rofi -show drun -drun-icon-theme "Yosa Max" -show-icons

under KDE and i3 and it shows me:

screenshot_20190124_220915

Of course, you will need an installed icon theme to replace "Yosa Max" with.

@markus1189
Copy link
Contributor

Nice, didn't now about the show-icons flag. Seems to work fine!

I am adding an application launcher, and icons for the googleearth
package. They are essentially just those in opt/ with the only
adjustment being to make the launcher execute the correct executable
file.
@fusion809
Copy link
Contributor Author

Just pushed a commit to include an icon in $out/share/pixmaps too, just in case for some reason the icons in hicolor are ignored.

@worldofpeace worldofpeace merged commit db7ccd4 into NixOS:master Jan 25, 2019
@worldofpeace
Copy link
Contributor

Thanks @fusion809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants