Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elvish: a small fixup #54531

Merged
merged 3 commits into from Jan 26, 2019
Merged

elvish: a small fixup #54531

merged 3 commits into from Jan 26, 2019

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 24, 2019 •
edited

Motivation for this change

Fixing version variable in order to properly download the source code.
Also, some minor stylistical modifications and additions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres
Elvish: a small fixup
c771f9f 
Fixing version variable in order to properly download the source code.
Also, some minor stylistical modifications and additions.
@etu
Copy link
Contributor

etu commented Jan 24, 2019

@GrahamcOfBorg build elvish

etu
etu approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

worldofpeace
worldofpeace suggested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well also switch to using pname.
Also the attribute in the commit msg should be elvish.

@Mic92 Mic92 changed the title Elvish: a small fixup elvish: a small fixup Jan 24, 2019
@AndersonTorres
Copy link
Member Author

@worldofpeace can you explain that pname thing?

@worldofpeace
Copy link
Contributor

name will default to the values of attributes pname = "elvish" and version = "0.12"; when both are present.

Mic92 and others added 2 commits January 26, 2019 10:11
@Mic92
elvish: use pname
3bb27a6
@worldofpeace @AndersonTorres
Update pkgs/shells/elvish/default.nix
dfca0ef 
Use `pname` instead of `name`.

Co-Authored-By: AndersonTorres <torres.anderson.85@protonmail.com>
@AndersonTorres
Copy link
Member Author

Something more to be done, people?

@worldofpeace worldofpeace merged commit 675ebc5 into NixOS:master Jan 26, 2019
@worldofpeace
Copy link
Contributor

Sorry, thanks for the fix ❇️

@AndersonTorres AndersonTorres deleted the release/elvish branch January 29, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@etu etu etu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AndersonTorres @etu @worldofpeace @GrahamcOfBorg @Mic92