Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wine{stable,unstable,staging,mono} #54522

Merged
merged 5 commits into from Feb 18, 2019
Merged

Update wine{stable,unstable,staging,mono} #54522

merged 5 commits into from Feb 18, 2019

Conversation

tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented Jan 24, 2019 •
edited

Motivation for this change

Wine 4 was released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build wine

@veprbl veprbl mentioned this pull request Jan 31, 2019
Closed
10 tasks
@avnik
Copy link
Contributor

avnik commented Feb 2, 2019

@worldofpeace ping!

@worldofpeace
Copy link
Contributor

Testing this today 👍

@ikervagyok
Copy link
Contributor

ikervagyok commented Feb 12, 2019 •
edited

just found this as i wanted to create a pr myself ;)
can you update wine staging and unstable to 4.1? (ikervagyok@34fc220)

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/27

@ikervagyok
Copy link
Contributor

wine is at 4.2 now, as is staging

@lheckemann lheckemann added this to the 19.03 milestone Feb 18, 2019
lheckemann
lheckemann approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running GNU hello (pkgsCross.mingw32.hello) with each wine version.

@lheckemann lheckemann merged commit b551657 into NixOS:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
19.03
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tadeokondrak @worldofpeace @avnik @ikervagyok @nixos-discourse @lheckemann @GrahamcOfBorg