Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redmine: add missing 'migrate' command prior to starting the application #54524

Merged
merged 2 commits into from Jan 29, 2019

Conversation

aanderse
Copy link
Member

required for plugins with a database component
see: http://www.redmine.org/projects/redmine/wiki/Plugins

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg test redmine

@samueldr
Copy link
Member

@GrahamcOfBorg build nixosTests.redmine

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nix-online-meetup/1919/4

@aanderse
Copy link
Member Author

aanderse commented Jan 25, 2019

Once more...
@GrahamcOfBorg test redmine

Test runs and succeeds locally. Seems to be an issue with GrahamcOfBorg me failing to properly read logs...

@GrahamcOfBorg build darcs

@aanderse
Copy link
Member Author

@peti & @domenkozar any thoughts on why darcs is failing here?

@peti
Copy link
Member

peti commented Jan 26, 2019

darcs does not compile at the moment: #53433.

@aanderse
Copy link
Member Author

@peti thanks for clarification

@aanderse
Copy link
Member Author

Now that darcs has been fixed:

@GrahamcOfBorg test redmine

@aanderse
Copy link
Member Author

@7c6f434c any interest on merging this, as you're the only person with any context on this package since it was brought back? Fairly straight forward.

@7c6f434c
Copy link
Member

So.

@GrahamcOfBorg build nixosTests.redmine

@globin are you running the latest ofborg?

@aanderse as I am neither a Ruby person nor NixOS user so I didn't focus on that PR when skimming the stream. But yes, ny remainders of pieces of knowledge about Redmine tell me that this addition makes a lot of sense.

@7c6f434c 7c6f434c merged commit 423e26a into NixOS:master Jan 29, 2019
@aanderse aanderse deleted the redmine branch January 29, 2019 22:36
@aanderse
Copy link
Member Author

@7c6f434c always appreciated! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants