Fix python2 str(circuits.core.values.Value()) #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure why Value has a __str__ method at all. But it's broken on
python2. It assumes value is always a unicode-string, while coroutines
can return anything, even lists. This causes various crashes.
>>> str(circuits.core.values.Value())
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/fbest/git/circuits/circuits/six.py", line 854, in <lambda>
klass.__str__ = lambda self: self.__unicode__().encode('utf-8')
File "/home/fbest/git/circuits/circuits/core/values.py", line 78, in __str__
return self.value.encode('utf-8')
AttributeError: 'NoneType' object has no attribute 'encode'
|
It exists mostly for debugability. |
prologic
approved these changes
Jan 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
=========================================
Coverage ? 74.49%
=========================================
Files ? 74
Lines ? 6665
Branches ? 0
=========================================
Hits ? 4965
Misses ? 1700
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why Value has a
__str__method at all. But it's broken onpython2. It assumes value is always a unicode-string, while coroutines
can return anything, even lists. This causes various crashes.