Improove error handling during TLS handshake #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if client already disconnected immediately.
Traceback (most recent call last):
File "/home/spaceone/git/circuits/circuits/core/manager.py", line 834, in processTask
value = next(task)
File "/home/spaceone/git/circuits/circuits/net/sockets.py", line 614, in _accept
self._on_accept_done(newsock)
File "/home/spaceone/git/circuits/circuits/net/sockets.py", line 636, in _on_accept_done
self.fire(connect(sock, *sock.getpeername()))
File "/usr/lib/python2.7/socket.py", line 228, in meth
return getattr(self._sock,name)(*args)
error: [Errno 107] Transport endpoint is not connected
prologic
approved these changes
Jan 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=========================================
+ Coverage 74.49% 74.5% +<.01%
=========================================
Files 74 74
Lines 6665 6671 +6
=========================================
+ Hits 4965 4970 +5
- Misses 1700 1701 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if client already disconnected immediately.