Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] home-assistant: 0.85.1 -> 0.86.4 #54541

Merged
merged 4 commits into from Feb 6, 2019
Merged

[WIP] home-assistant: 0.85.1 -> 0.86.4 #54541

merged 4 commits into from Feb 6, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 24, 2019 •
edited

Motivation for this change

https://www.home-assistant.io/blog/2019/01/23/release-86/

I'm still in the process of adding a lovelaceConfig option to the NixOS module. I have however no experience with Lovelace and hope one of you guys might have some insight into wether this seems useful and what to think about when adding it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

I have a ton of HA customizations and am also writing out lovelaceConfig from here as well. That probably should be mostly upstreamed... It's basically just a very large attrSet with some helpers thrown in to automate certain elements.

@dotlambda
Copy link
Member Author

Sound nice! I'll push what I have so you can have a look at it. Feel free to discard mine and push your own commit to this branch.

@dotlambda dotlambda changed the title [WIP] home-assistant: 0.85.1 -> 0.86.1 [WIP] home-assistant: 0.85.1 -> 0.86.2 Jan 25, 2019
@dotlambda dotlambda force-pushed the home-assistant-0.86 branch 2 times, most recently from 3663602 to d1b8883 Compare January 27, 2019 12:41
@dotlambda dotlambda requested a review from FRidh as a code owner January 27, 2019 12:41
@dotlambda dotlambda changed the title [WIP] home-assistant: 0.85.1 -> 0.86.2 [WIP] home-assistant: 0.85.1 -> 0.86.3 Jan 27, 2019
@dotlambda dotlambda removed the request for review from FRidh January 27, 2019 12:42
@dotlambda dotlambda changed the title [WIP] home-assistant: 0.85.1 -> 0.86.3 [WIP] home-assistant: 0.85.1 -> 0.86.4 Jan 29, 2019
@dotlambda
Copy link
Member Author

@peterhoeg Any news?

@peterhoeg
Copy link
Member

I haven't had the time to try it out but it looks safe enough except for one thing. It's possible to edit the lovelace UI directly from the web interface, so instead of symlinking we probably should copy it. Instead of going through a whole nixops deploy cycle when shifting some minor things around, I was previously editing the lovelace config file directly and then consolidating all the changes when done. I don't think that will work when the file is read-only.

peterhoeg
peterhoeg approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@peterhoeg peterhoeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterhoeg peterhoeg merged commit 7003a28 into NixOS:master Feb 6, 2019
@dotlambda dotlambda deleted the home-assistant-0.86 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @peterhoeg @pSub @GrahamcOfBorg