Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/google-compute-image: don't use <nixpkgs> #54539

Merged
merged 1 commit into from Jan 28, 2019
Merged

nixos/google-compute-image: don't use <nixpkgs> #54539

merged 1 commit into from Jan 28, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 24, 2019

Motivation for this change

Avoid loading code from the NIX_PATH as it prevents pinning

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from flokli January 24, 2019 14:00
flokli
flokli requested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, only the second part should be changed, but I'd appreciate somebody else taking another look over it!

nixos/modules/virtualisation/google-compute-config.nix Outdated Show resolved Hide resolved
nixos/modules/virtualisation/google-compute-image.nix Show resolved Hide resolved
@flokli
Copy link
Contributor

flokli commented Jan 28, 2019

@zimbatm can you drop the change from nixos/modules/virtualisation/google-compute-config.nix, so this can be merged?

@zimbatm
nixos/google-compute-image: don't use <nixpkgs>
622f97a 
Avoid loading code from the NIX_PATH as it prevents pinning
@zimbatm zimbatm force-pushed the release-18.09-google-compute-image-fix branch from e999ec0 to 622f97a Compare January 28, 2019 10:39
@zimbatm zimbatm merged commit e39e43a into NixOS:release-18.09 Jan 28, 2019
@zimbatm zimbatm deleted the release-18.09-google-compute-image-fix branch January 28, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

@memberbetty memberbetty memberbetty approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimbatm @flokli @memberbetty @GrahamcOfBorg